-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom protocol name #962
feat: custom protocol name #962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this support. I left a couple of suggestions to get this to the finish line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks much cleaner now!
We should just add a test file in https://github.com/libp2p/js-libp2p/tree/master/test/configuration where we configure a different prefix and verify if node.peerStore.protoBook.get(node.peerId)
contains the expected protocols
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@greenSnot there is still one issue that we need to solve. The linting job is failing with the following errors
You can run |
@greenSnot apologies, but you will need to rebase this PR. We had an issue in CI that I saw in this PR and I already fixed it in #963 but now we need a rebase to get this fixed here and get CI jobs green |
013ce6e
to
1262691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for getting this to the finish line
No description provided.