Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: main action node setup and browser example CI #963

Merged
merged 2 commits into from
Aug 12, 2021
Merged

fix: main action node setup and browser example CI #963

merged 2 commits into from
Aug 12, 2021

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Aug 12, 2021 •
edited
Loading

This PR addresses two issues:

  • Tests were not running as the previous yaml action format was erroring (silently) and it got unnoticed as CI was still running but just for examples 😱
  • Browser tests were failing due to parcel changes

@vasco-santos vasco-santos changed the title chore: update action setup node fix: main action node setup and browser example CI Aug 12, 2021
@vasco-santos vasco-santos merged commit 3b33fb4 into master Aug 12, 2021
@vasco-santos vasco-santos deleted the chore/update-action-setup-node branch August 12, 2021 13:15
@vasco-santos vasco-santos mentioned this pull request Aug 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vasco-santos