Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] wrong dependency declaration #986

Closed
onichandame opened this issue Sep 4, 2021 · 4 comments · Fixed by #992
Closed

[bug] wrong dependency declaration #986

onichandame opened this issue Sep 4, 2021 · 4 comments · Fixed by #992
Labels
need/triage Needs initial labeling and prioritization

Comments

@onichandame
Copy link
Contributor

Problem

The abortable-iterator package is a direct dependency as it is required by src/dialer/index.js. But it is declared in the devDependencies section which results in a missing module error.

Solution

move abortable-iterator from devDeps to deps
@onichandame onichandame added the need/triage Needs initial labeling and prioritization label Sep 4, 2021
@itseasy21
Copy link

bump

D:/React-WorkSpace/COSC2410_SEM_2_2021/.yarn/cache/libp2p-npm-0.32.4-fe607aff53-99957c9e00.zip/node_modules/libp2p/src/dialer/index.js Module not found: libp2p tried to access abortable-iterator, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

@itseasy21 itseasy21 mentioned this issue Sep 17, 2021
Closed
@achingbrain
Copy link
Member

Could you open a PR that fixes this please?

@onichandame
Copy link
Contributor Author

I'd like to, but before that, I need to know whether abortable-iterator should be a dependencies or peerDependencies

@achingbrain
Copy link
Member

dependencies

@onichandame onichandame mentioned this issue Sep 17, 2021
Merged
vasco-santos pushed a commit that referenced this issue Sep 21, 2021
@onichandame
fix: move abortable-iterator to dependencies (#992)
122c89d 
fix #986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move abortable-iterator to dependencies
3 participants
@achingbrain @itseasy21 @onichandame