Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strict dependencies to fix build #1205

Closed
wants to merge 1 commit into from

Conversation

abetaev
Copy link
Contributor

@abetaev abetaev commented May 4, 2022

hi,

at some point i came up with necessity to build js-libp2p, but found that it's not buildable.

this change was the cause (libp2p/interfaces)

if semver rules were followed this shouldn't have happened.

@achingbrain
Copy link
Member

Thanks for the PR. The relevant changes needed to support the updated interfaces have been done as part of #1206 so if you pull from master and reinstall the node deps it should build successfully again.

if semver rules were followed this shouldn't have happened.

This project is in a bit of a weird space while we transition to TypeScript - the interfaces have grown organically over time so are subject to a bit of churn while we apply the learnings of the past few years to them so there will be some breakage. The good news is this breakage is contained to the @libp2p/* modules and libp2p@next - the previous 0.36.x release tree is unaffected because it doesn't use and @libp2p/* modules.

Long story short: as soon as #1178 is merged and 0.37.x is released, semver will be strictly followed again. In the interim you should use the 0.36.x release (see releases for the latest tag) and not libp2p@next or master.

@achingbrain achingbrain closed this May 4, 2022
@abetaev abetaev deleted the fix/build-deps branch May 5, 2022 00:49
@abetaev
Copy link
Contributor Author

abetaev commented May 5, 2022

thank you for the news and the explanation, it makes things clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants