feat!: limit protocol streams per-connection #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the `maxInboundStreams` and `maxOutboundStreams` of the `registrar.handle` opts to limit the number of concurrent streams open on each connection on a per-protocol basis. Both values default to 1 so some tuning will be necessary to set appropriate values for some protocols.
achingbrain
changed the title
mpetrunic
reviewed
Jun 17, 2022
| @@ -79,13 +79,21 @@ const DefaultConfig: Partial<Libp2pInit> = { | |||
| host: { | |||
| agentVersion: AGENT_VERSION | |||
| }, | |||
| timeout: 30000 | |||
| timeout: 30000, | |||
| maxInboundStreams: 1, | |||
There was a problem hiding this comment.
should we also mention this in breaking the change changelog?
We should bring to attention that users will need to override defaults :smiles
There was a problem hiding this comment.
Sounds good. The text after "BREAKING CHANGE:" in the squashed commit message (e.g. copy/pasted from the OP in this PR) will be added to the changelog on release by semantic-release.
wemeetagain
approved these changes
Jun 17, 2022
Merged
This was referenced Jul 24, 2022
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
maxInboundStreamsandmaxOutboundStreamsof theregistrar.handleopts to limit the number of concurrent streams open on each connection on a per-protocol basis.Both values default to 1 so some tuning will be necessary to set appropriate values for some protocols before release.
Also refactors the fetch protocol implementation as it turns out it wasn't closing streams after receiving responses 😬
BREAKING CHANGE:
libp2p.dialProtocolreturns a stream with astat.protocolproperty instead of an object withstreamandprotocolproperties. Protocol handlers also need to specify how many inbound/outbound streams are allowed