-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade aegir #1566
chore: upgrade aegir #1566
Conversation
It appears that it needs to be bumped in libp2p-interop repo first^^ |
Thanks @mpetrunic, turns out @achingbrain had already addressed this I must have overlooked the comment. This is blocked until libp2p/interop#82 is merged. |
libp2p/interop#82 has been merged and released, now there are a couple of hundred tedious linting errors to tidy up. I think we should try to get #1533 in first as fixing all the linting noise here will cause many, many conflicts in that branch so let's pause on this until the circuit relay v2 stuff is in. |
f03e23a
to
bb9772c
Compare
6ff2e6b
to
9ed169b
Compare
664e475
to
93fc6d4
Compare
93fc6d4
to
92edb4a
Compare
Thanks @p-shahi , it's ready to be reviewed now @achingbrain @mpetrunic but I think we should look to get #1579 and #1619 merged first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates aegir, fixes all linting and dep issues. Co-authored-by: achingbrain <alex@achingbrain.net>
* chore: upgrade aegir (libp2p#1566) Updates aegir, fixes all linting and dep issues. Co-authored-by: achingbrain <alex@achingbrain.net> * Fix linting errors * Add package-lock.json * fix: use @libp2p/keychain module instead of bundling source code (libp2p#1569) The @libp2p/keychain module has the keychain code split out from this module so use that instead of bundling the code here. It's also dropped it's dependency on `node-forge` so it's now only in `@libp2p/crypto`. * Fix dependencies * Avoid upgrading go-libp2p for interop tests --------- Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: achingbrain <alex@achingbrain.net>
Following the conversation here this will allow us to address #1505