fix: invoke onProgress callback with DHT queries during routing #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow passing an `onProgress` callback to the peer/content routers that can receive DHT query events. Experimental for now.
maschad
reviewed
Mar 27, 2023
src/dht/dht-content-routing.ts
Outdated
| for await (const event of this.dht.findProviders(cid, options)) { | ||
| options.onProgress?.(new CustomProgressEvent('content-routing:find-providers:dht:event', event)) |
There was a problem hiding this comment.
We could extract these event names to be consts and then reuse them.
maschad
reviewed
Mar 27, 2023
|
|
||
| const onProgress = sinon.stub() | ||
|
|
||
| await drain(nodes[0].contentRouting.findProviders(CID.parse('QmU621oD8AhHw6t25vVyfYKmL9VV3PTgc52FngEhTGACFB'), { |
There was a problem hiding this comment.
It's used elsewhere in the test suite 🤷
|
Converted to draft because we need to be a bit cleverer about how we expose the If we don't expose them all we get errors: await name.resolve(key, {
onProgress(evt) {
if (evt.type === 'content-routing:get:dht:event') {
}
}
})The problem is we want to avoid exposing all the ProgressEvent types for all the content routing/peer routing implementations at the content routing/peer routing interface level. Better to somehow aggregate the types based on the configuration passed to the libp2p factory function in a similar way to #1563 |
|
Closing in favour of #1975 |
achingbrain
deleted the
fix/call-progress-callback-for-content-and-peer-routing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing an
onProgresscallback to the peer/content routers that can receive DHT query events.Refs #1574