-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: refactor connection manager to use a prioritised queue #1678
Merged
Commits on Apr 11, 2023
-
fix!: refactor connection manager to use a queue and add priority dia…
…ling Refactors the connection manager. 1. Internally it uses a queue to control concurrency instead of dial tokens 2. A second queue is used for each peer to prevent inividual peers from swamping the dial queue 3. The auto dialler now checks the minimum connection limit when peers disconnect instead of using a timer 4. Auto dialled peers are sorted based on tag value so valuable peers should be re-dialled first 5. Auto dialled peers are dialled in parallel to prevent a slow peer locking up the auto-dial queue 6. allow/deny lists are now `MultiaddrFilter`s 7. A `getDialQueue` method has been added to libp2p to allow inspection of the dial queue though it needs exposing in the interface 8. The connection gater `denyDialMultiaddr` method now only takes a multiaddr BREAKING CHANGE: some connection manager options have changed - please see the upgrade guide for full details
Configuration menu - View commit details
-
Copy full SHA for 125878e - Browse repository at this point
Copy the full SHA 125878eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b66103 - Browse repository at this point
Copy the full SHA 3b66103View commit details -
chore: apply suggestions from code review
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e2f406b - Browse repository at this point
Copy the full SHA e2f406bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee7cd99 - Browse repository at this point
Copy the full SHA ee7cd99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ff8ed5 - Browse repository at this point
Copy the full SHA 6ff8ed5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d92f93 - Browse repository at this point
Copy the full SHA 3d92f93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e802d9 - Browse repository at this point
Copy the full SHA 1e802d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for dec86ff - Browse repository at this point
Copy the full SHA dec86ffView commit details
Commits on Apr 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4c4ab3b - Browse repository at this point
Copy the full SHA 4c4ab3bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.