Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: exposed and documented #169

Merged
merged 2 commits into from
Mar 15, 2018
Merged

stats: exposed and documented #169

merged 2 commits into from
Mar 15, 2018

Conversation

pgte
Copy link
Contributor

@pgte pgte commented Feb 23, 2018

Fixes #168

@ghost ghost assigned pgte Feb 23, 2018
@ghost ghost added the status/in-progress In progress label Feb 23, 2018
@pgte pgte requested a review from daviddias February 23, 2018 13:25
victorb
victorb reviewed Feb 23, 2018
View reviewed changes
test/stats.js Outdated

describe('libp2p', (done) => {
it('has stats', () => {
createNode('/ip4/0.0.0.0/tcp/0', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to set address to 127.0.0.1 instead, no reason to bind to public interface :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victorbjelkholm good call, thanks! Fixed by 10bd08b.

@ghost ghost assigned hacdias Feb 27, 2018
@hacdias
Copy link
Member

hacdias commented Feb 27, 2018

@pgte just updated the version of libp2p-switch on package.json to see if the tests work 😄

@hacdias hacdias mentioned this pull request Feb 27, 2018
Merged
9 tasks
@hacdias
Copy link
Member

hacdias commented Mar 3, 2018

Any updates here?

daviddias
daviddias suggested changes Mar 3, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is all failing.

@hacdias
Copy link
Member

hacdias commented Mar 4, 2018 •
edited
Loading

The tests seem to be failing on some (not directly) related code to stats:

js-libp2p/test/peer-routing.node.js

Lines 52 to 60 in 7eb1166

after((done) => {
parallel([
(cb) => nodeA.stop(cb),
(cb) => nodeB.stop(cb),
(cb) => nodeC.stop(cb),
(cb) => nodeD.stop(cb),
(cb) => nodeE.stop(cb)
], done)
})

/cc @pgte

@daviddias
Copy link
Member

@dryajov did something change on circuit-relay?

image

@hacdias
Copy link
Member

hacdias commented Mar 9, 2018

Ping @pgte

@pgte
Copy link
Contributor Author

pgte commented Mar 9, 2018

@hacdias my build runs locally, but I'm trying to figure out what's happening on CI..

@daviddias
Copy link
Member

@pgte suggestion: try to rebase master onto this branch, it might solve your issue.

@hacdias
Copy link
Member

hacdias commented Mar 11, 2018

@pgte @diasdavid just rebased into master and the issue persists. I'm using the last commit from here on ipfs/js-ipfs#1230 and it seems to be working well.

@daviddias
Copy link
Member

This one is stale for a while, what's blocking from getting CI green?

@pgte
Copy link
Contributor Author

pgte commented Mar 12, 2018

Working on this now.

@pgte
Copy link
Contributor Author

pgte commented Mar 12, 2018

Related: libp2p/js-libp2p-switch#246

@pgte pgte mentioned this pull request Mar 12, 2018
Merged
@pgte
Copy link
Contributor Author

pgte commented Mar 12, 2018

I cannot reproduce this locally, but the error traces suggest that this PR for libp2p-switch should ameliorate this.

@daviddias
Copy link
Member

restarted CI now that libp2p-switch fix has been merged and released as a patch version.

@pgte
Copy link
Contributor Author

pgte commented Mar 12, 2018

@diasdavid thanks! That fixed some issues, but now I have node v6-only failings I'm going to dive into..

@pgte
Copy link
Contributor Author

pgte commented Mar 12, 2018

Update: for some reason, in node.js v6, in some instances, peerInfo.id is a buffer and not a peer-id instance..

@pgte
Copy link
Contributor Author

pgte commented Mar 12, 2018

I think I found the problem, and it's in libp2p-circuit: libp2p/js-libp2p-circuit#23

If ok, needs updating libp2p-circuit and downstream libp2p-switch and libp2p.

@pgte pgte mentioned this pull request Mar 13, 2018
Merged
@ghost ghost assigned daviddias Mar 14, 2018
daviddias
daviddias approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if it runs now :)

@daviddias
Copy link
Member

@pgte a new consistent error as arise: https://travis-ci.org/libp2p/js-libp2p/builds/353334562#L4862

@pgte
Copy link
Contributor Author

pgte commented Mar 15, 2018

One last edge case fixed in the switch observer: libp2p/js-libp2p-switch#248

It should all be ok after this switch fix:

1__bash

@daviddias daviddias merged commit 4527d5f into master Mar 15, 2018
@daviddias daviddias deleted the feat/stats branch March 15, 2018 15:10
@ghost ghost removed the status/in-progress In progress label Mar 15, 2018
@snyk-bot snyk-bot mentioned this pull request Apr 8, 2022
Open
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@dependabot
deps: bump @multiformats/multiaddr from 11.6.1 to 12.0.0 (libp2p#169)
3532982 
Bumps [@multiformats/multiaddr](https://github.com/multiformats/js-multiaddr) from 11.6.1 to 12.0.0.
- [Release notes](https://github.com/multiformats/js-multiaddr/releases)
- [Changelog](https://github.com/multiformats/js-multiaddr/blob/master/CHANGELOG.md)
- [Commits](multiformats/js-multiaddr@v11.6.1...v12.0.0)

---
updated-dependencies:
- dependency-name: "@multiformats/multiaddr"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@semantic-release-bot
chore(release): 6.0.2 [skip ci]
4877f5a 
## [6.0.2](libp2p/js-libp2p-bootstrap@v6.0.1...v6.0.2) (2023-03-17)

### Dependencies

* bump @multiformats/multiaddr from 11.6.1 to 12.0.0 ([libp2p#169](libp2p/js-libp2p-bootstrap#169)) ([3532982](libp2p/js-libp2p-bootstrap@3532982))
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@dependabot
deps(dev): bump delay from 5.0.0 to 6.0.0 (libp2p#169)
104cbf0 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@semantic-release-bot
chore(release): 2.0.9 [skip ci]
54f15eb 
## [2.0.9](libp2p/js-libp2p-webrtc@v2.0.8...v2.0.9) (2023-06-12)

### Dependencies

* **dev:** bump delay from 5.0.0 to 6.0.0 ([libp2p#169](libp2p/js-libp2p-webrtc#169)) ([104cbf0](libp2p/js-libp2p-webrtc@104cbf0))
achingbrain added a commit that referenced this pull request Jun 27, 2023
@achingbrain
deps: update project deps to support no-copy operations (#169)
6a129b7
achingbrain pushed a commit that referenced this pull request Jun 27, 2023
@semantic-release-bot
chore(release): 3.0.3 [skip ci]
7a71fff 
## [3.0.3](libp2p/js-libp2p-floodsub@v3.0.2...v3.0.3) (2022-08-03)

### Dependencies

* update project deps to support no-copy operations ([#169](libp2p/js-libp2p-floodsub#169)) ([6a129b7](libp2p/js-libp2p-floodsub@6a129b7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorb victorb victorb left review comments

@daviddias daviddias daviddias approved these changes

Assignees

@pgte pgte

@daviddias daviddias

@hacdias hacdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgte @hacdias @daviddias @victorb