Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Interop test for webrtc and webrtc-direct #1788

Merged
merged 11 commits into from
Jun 7, 2023

Conversation

MarcoPolo
Copy link
Collaborator

@MarcoPolo MarcoPolo commented Jun 2, 2023

Adds browser to browser tests and enables the webrtc-direct tests.

Firefox will fail until: libp2p/js-libp2p-webrtc#179 is merged.

@MarcoPolo MarcoPolo marked this pull request as ready for review June 7, 2023 01:56
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcoPolo MarcoPolo merged commit 2165bc2 into master Jun 7, 2023
@MarcoPolo MarcoPolo deleted the marco/js-libp2p-interop-b2b branch June 7, 2023 19:54
@achingbrain
Copy link
Member

This is broken in master. It looks like it runs more test variations there than the CI run on this PR:

Master:

image

https://github.com/libp2p/js-libp2p/actions/runs/5251996577

This PR:

image

https://github.com/libp2p/js-libp2p/actions/runs/5201404450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants