Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove quic from ping interop test #1807

Merged
merged 2 commits into from
Jun 22, 2023
Merged

chore: remove quic from ping interop test #1807

merged 2 commits into from
Jun 22, 2023

Conversation

p-shahi
Copy link
Member

@p-shahi p-shahi commented Jun 13, 2023 •
edited
Loading

closes libp2p/test-plans#142

Don't think this should be an issue because quic shouldn't get passed into the js tests. We can re-add it once quic support lands for node.js

@p-shahi
Copy link
Member Author

p-shahi commented Jun 14, 2023 •
edited
Loading

tests failing due to #1809
Will wait for #1809 before taking this pr

@maschad
Copy link
Member

maschad commented Jun 21, 2023

Once #1845 is merged we can rebase and merge this.

@maschad maschad self-assigned this Jun 21, 2023
@maschad maschad merged commit 05abd49 into master Jun 22, 2023
@maschad maschad deleted the update-interop-test branch June 22, 2023 02:32
@p-shahi p-shahi mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees

@maschad maschad

Labels
None yet
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS test references "quic" in a few places
3 participants
@p-shahi @maschad @MarcoPolo