-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: publish multidim interop test module #2008
Conversation
This module is now published as `@libp2p/multidim-interop`. Closes #2005
".aegir.js", | ||
"BrowserDockerfile", | ||
"chromium-version.json", | ||
"Dockerfile", | ||
"firefox-version.json", | ||
"Makefile", | ||
"node-version.json", | ||
"relay.js", | ||
"tsconfig.json", | ||
"webkit-version.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is all the files needed in the published tarball?
@libp2p/js-libp2p-dev Please review, this is needed to unblock WebRTC testing efforts for libp2p/go-libp2p#2337 |
https://www.npmjs.com/package/@libp2p/multidim-interop has already been published which can be used right now to unblock testing efforts but this PR is needed to publish any further updates to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I think we should merge #2006 first though
Thanks for clearing that up - who is taking care of libp2p/test-plans#288 and libp2p/test-plans#286 @achingbrain or @maschad ? |
I am working on those. Now that https://www.npmjs.com/package/@libp2p/multidim-interop is published I can re-run the workflow for libp2p/test-plans#288 but I will need #2006 to unblock libp2p/test-plans#286 for AArch64 cpu architectures for now. |
#2006 - I think this patch needs to be applied to the test plans, then |
This module is now published as
@libp2p/multidim-interop
.Closes #2005