Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(@multidim-interop): add aegir to deps #2023

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Sep 5, 2023

This whole package should have aegir as a dep since it's core functionality is built around testing js-libp2p with aegir via the test command but especially In order to utilize aegir for browser multidim interop testing we should add aegir as a dependency here.

Related: libp2p/test-plans#288

Copy link
Member

@p-shahi p-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamping

@maschad maschad merged commit c4eff4c into libp2p:master Sep 5, 2023
15 of 17 checks passed
@maschad maschad deleted the deps/add-aegir-interop-dep branch September 5, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants