fix(@libp2p/webrtc): use stream logger instead of global logger #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streams should use the `this.log` property for logging to ensure the log messages are scoped to an invidual stream.
maschad
requested changes
Sep 12, 2023
|
It's created in the stream factory and passed into the constructor? |
|
It's less obvious than if it was initialized in the constructor 🤷🏾 |
|
My opinion is not very strong, but as it is it's consistent with yamux and mplex (WebTransport doesn't have per-stream loggers, it should). This can be done as a follow up PR if necessary, it is out of scope here. |
maschad
approved these changes
Sep 12, 2023
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Sep 27, 2023
…2p#2042) Streams should use the `this.log` property for logging to ensure the log messages are scoped to an invidual stream.
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streams should use the
this.logproperty for logging to ensure the log messages are scoped to an invidual stream.