Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close webrtc streams without data loss #2073

Merged
merged 17 commits into from
Oct 6, 2023
Merged

fix: close webrtc streams without data loss #2073

merged 17 commits into from
Oct 6, 2023

Commits on Sep 23, 2023

  1. fix: close webrtc streams

    @achingbrain
    achingbrain committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    30b2513 View commit details
    Browse the repository at this point in the history

  2. chore: revert aegir change

    @achingbrain
    achingbrain committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    005ddbf View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. chore: fix up tests

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d4ef6ca View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/webrtc-stream-closing

    @achingbrain
    achingbrain authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    772cc10 View commit details
    Browse the repository at this point in the history

  3. chore: fix deps

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    7a6e0b4 View commit details
    Browse the repository at this point in the history

  4. chore: fix linting

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ae2bdf6 View commit details
    Browse the repository at this point in the history

  5. chore: fix deps

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    519e472 View commit details
    Browse the repository at this point in the history

  6. chore: add comment

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0425b20 View commit details
    Browse the repository at this point in the history

  7. chore: update dep

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e8f9730 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. fix: close webrtc streams (#2074) 

    Chrome does not always send all messages after closing a datachannel
even if `bufferedAmount` is `0` before closing.

This PR adds a `FIN_ACK` message that is sent in reply to a `FIN`
message - because all messages are send in-order, when this is
received we know the remote has received all of our data messages
and it's safe to close the channel.
    @achingbrain
    achingbrain authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ac92ec7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into fix/webrtc-stream-c… 

    …losing
    @achingbrain
    achingbrain committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    0480b34 View commit details
    Browse the repository at this point in the history

  3. chore: pr comments

    @achingbrain
    achingbrain committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    61c48a1 View commit details
    Browse the repository at this point in the history

  4. chore: fix deps

    @achingbrain
    achingbrain committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    edd080b View commit details
    Browse the repository at this point in the history

  5. chore: remove commented code

    @achingbrain
    achingbrain committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    aeb57a4 View commit details
    Browse the repository at this point in the history

  6. chore: fix race conditions when both ends close a datachannel

    @achingbrain
    achingbrain committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2e6f55d View commit details
    Browse the repository at this point in the history

  7. chore: apply suggestions from code review 

    Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
    @achingbrain @maschad
    achingbrain and maschad authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4436184 View commit details
    Browse the repository at this point in the history

  8. chore: ensure all config options mention their units

    @achingbrain
    achingbrain committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    276f146 View commit details
    Browse the repository at this point in the history