Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README structure #2115

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Oct 3, 2023

Title

docs: update README structure and contributing guidelines

Description

I have updated the structure of the README to be a bit more welcoming by moving monorepo file structure below the ## Project Status. The assumption is that a first time consumer is less interested in the monorepo as opposed to just installing and using the library.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@maschad maschad requested a review from a team as a code owner October 3, 2023 01:28
@maschad maschad self-assigned this Oct 3, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
@maschad maschad force-pushed the docs/update-contributing-guide branch from 701bc70 to 05015a1 Compare October 4, 2023 01:47
@maschad maschad changed the title docs: update README structure and contributing guidelines docs: update README structure Oct 4, 2023
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the logo and a set of badges are now in the middle of the document - please can you move them back up to the top.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much more welcoming

@maschad maschad merged commit 980857c into libp2p:master Oct 5, 2023
17 checks passed
@maschad maschad deleted the docs/update-contributing-guide branch October 5, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants