Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #221

Merged
merged 1 commit into from
Jul 13, 2018
Merged

chore: update deps #221

merged 1 commit into from
Jul 13, 2018

Conversation

daviddias
Copy link
Member

No description provided.

@ghost ghost assigned daviddias Jul 13, 2018
@ghost ghost added the status/in-progress In progress label Jul 13, 2018
@daviddias
Copy link
Member Author

The new libp2p-switch is causing (or revealed):

  1) .contentRouting le ring nodeA.contentRouting.provide:

     Error: stream ended with:0 but wanted:1

      at drain (node_modules/pull-reader/index.js:43:26)

      at node_modules/pull-reader/index.js:63:18

      at node_modules/pull-reader/index.js:114:13

      at node_modules/pull-reader/index.js:114:13

      at onNext (node_modules/pull-catch/index.js:17:17)

      at drain (node_modules/stream-to-pull-stream/index.js:141:18)

      at Channel.<anonymous> (node_modules/stream-to-pull-stream/index.js:158:5)

      at endReadableNT (node_modules/readable-stream/lib/_stream_readable.js:1010:12)

      at process._tickCallback (internal/process/next_tick.js:63:19)

@jacobheun
Copy link
Contributor

@diasdavid this is related to the latest update to pull-reader and an edge case with pull-length-prefixed. dignifiedquire/pull-length-prefixed#8. I will get that PR rebased so we can get that released, which should fix the issue.

@jacobheun
Copy link
Contributor

The pull-reader update exposed a bug in the dht where were were reading on write only responses. The dht is still working properly, but since we're getting no data when add providers, which is expected, we pull-reader errors because we tried to read a byte.

libp2p/js-libp2p-kad-dht#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants