fix: graceful close of optimistic selection with early data #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are doing optimistic protocol selection and we send a small amount of data then immediately close the stream, if necessary wait until we have finished sending protocol+data before allowing the underlying stream to close.
achingbrain
force-pushed
the
fix/allow-mss-to-finish
branch
from
55687b5
to
9da16d1
Compare
achingbrain
force-pushed
the
fix/allow-mss-to-finish
branch
from
c9db5f0
to
dba5e37
Compare
Merged
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are doing optimistic protocol selection and we send a small amount of data then immediately close the stream, if necessary wait until we have finished sending protocol+data before allowing the underlying stream to close.
Change checklist