feat: add negotiateFully option when opening streams
#2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to `libp2p.dialProtocol` and `connection.newStream` to disable optimisitic protocol selection and default to waiting for negotation to finish before sending data. This increases the time-to-first-byte of a stream negotiated with a single protocol but restores the previous behaviour. Fixes #2321
maschad
approved these changes
Dec 20, 2023
Merged
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to
libp2p.dialProtocolandconnection.newStreamto enable optimistic protocol selection but defaults to waiting for negotiation to finish before sending data.This increases the time-to-first-byte of a stream negotiated with a single protocol but restores the previous behaviour.
Fixes #2321
Change checklist