Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase default DHT query timeout #2525

Merged
merged 2 commits into from
May 7, 2024
Merged

fix: increase default DHT query timeout #2525

merged 2 commits into from
May 7, 2024

Conversation

achingbrain
Copy link
Member

30s is not enough for a typical query with an empty routing table.

A typical time is more like 60s so increase to 180s to give headroom.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: increase default DHT query timeout
47fda04 
30s is not enough for a typical query with an empty routing table.

A typical time is more like 60s so increase to 180s to give headroom.
@achingbrain achingbrain requested a review from a team as a code owner May 5, 2024 11:07
@achingbrain achingbrain merged commit 1488a73 into main May 7, 2024
22 checks passed
@achingbrain achingbrain deleted the fix/increase-default-dht-query-timeout branch May 7, 2024 11:22
@achingbrain achingbrain mentioned this pull request May 7, 2024
Merged
@dhuseby dhuseby mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @maschad