Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make tcp closing error throwing consistent #2729

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: make tcp closing error throwing consistent #2729

merged 1 commit into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. fix: make tcp closing error throwing consistent 

    In the first close attempt we wrap the `closePromise` with a try/catch
and call `.abort` if it throws, and we don't propagate the error.

In the second invocation we return the `closePromise` which can reject
making the code non-deterministic.
    @achingbrain
    achingbrain committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4fa49f8 View commit details
    Browse the repository at this point in the history