Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add maxSize to queues #2742

Merged
merged 2 commits into from
Oct 2, 2024
Merged

feat: add maxSize to queues #2742

merged 2 commits into from
Oct 2, 2024

Conversation

achingbrain
Copy link
Member

Also restore accidentally deleted tests

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
feat: add maxSize to queues
fa84056 
Also restore accidentally deleted tests
@achingbrain achingbrain requested a review from a team as a code owner September 30, 2024 16:34
SgtPooki
SgtPooki approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@achingbrain achingbrain merged commit 116a887 into main Oct 2, 2024
21 checks passed
@achingbrain achingbrain deleted the feat/add-max-size-to-queue branch October 2, 2024 08:15
@achingbrain achingbrain mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @SgtPooki