Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace mafmt with @multiformats/multiaddr-matcher #2791

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: replace mafmt with @multiformats/multiaddr-matcher #2791

merged 2 commits into from
Oct 28, 2024

Conversation

achingbrain
Copy link
Member

Switches to the more modern library, notably because it has support for SNI tuples in multiaddrs.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner October 28, 2024 17:45
@achingbrain achingbrain changed the title fix: replace @multiformats/mafmt with @multiformats/multiaddr-matcher fix: replace mafmt with @multiformats/multiaddr-matcher Oct 28, 2024
@achingbrain achingbrain merged commit a5cd8cf into main Oct 28, 2024
34 checks passed
@achingbrain achingbrain deleted the fix/replace-mafmt-with-matcher branch October 28, 2024 18:18
@achingbrain achingbrain mentioned this pull request Oct 28, 2024
Merged
@2color 2color mentioned this pull request Oct 29, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain