Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move transport interface tests to integration package #2813

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

achingbrain
Copy link
Member

Breaks sibling dependencies between interface tests and transports which means a fix to the connection encrypter interface tests don't cause a tcp release which causes a libp2p release which causes a webrtc release.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Breaks sibling dependencies between interface tests and transports
which means a fix to the connection encrypter interface tests don't
cause a tcp release which causes a libp2p release which causes a
webrtc release.
@achingbrain achingbrain requested a review from a team as a code owner November 7, 2024 15:09
@achingbrain achingbrain merged commit 32ca76f into main Nov 7, 2024
34 checks passed
@achingbrain achingbrain deleted the chore/move-interface-tests-to-integration branch November 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant