fix: remove unneeded peerbook puts #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
approved these changes
Apr 5, 2019
src/index.js
Outdated
| @@ -246,7 +245,6 @@ class Node extends EventEmitter { | |||
|
|
|||
| this._switch.dial(peerInfo, protocol, (err, conn) => { | |||
There was a problem hiding this comment.
We can just pass the callback now. Lines below have to be removed
Suggested change
| this._switch.dial(peerInfo, protocol, (err, conn) => { | |
| this._switch.dial(peerInfo, protocol, callback) |
There was a problem hiding this comment.
Ah yeah, good call! I've updated those.
src/index.js
Outdated
| @@ -275,9 +273,6 @@ class Node extends EventEmitter { | |||
| if (err) { return callback(err) } | |||
|
|
|||
| this._switch.dialFSM(peerInfo, protocol, (err, connFSM) => { | |||
There was a problem hiding this comment.
Suggested change
| this._switch.dialFSM(peerInfo, protocol, (err, connFSM) => { | |
| this._switch.dialFSM(peerInfo, protocol, callback) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With libp2p/js-libp2p-kad-dht#92 the dht test for peer discovery was out of date. I fixed it and updated the other tests to use lower intervals so we dont have to wait 10seconds for discovery to happen.
The circuit tests were also inaccurate so those were fixed.
Switch had a significant number of code added recently, so the bundle size threshold needed to be increased slightly.