fix: connection emits #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
force-pushed
the
fix/connection-emits
branch
from
f7bff4d to
defc069
Compare
jacobheun
force-pushed
the
fix/connection-emits
branch
from
defc069 to
0935ad2
Compare
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
* fix: enable and fix browser tests * remove file selection in tests Co-authored-by: Marin Petrunic <marin.petrunic@gmail.com>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [6.0.1](libp2p/js-libp2p-kad-dht@v6.0.0...v6.0.1) (2022-11-07) ### Bug Fixes * enable and fix browser tests ([libp2p#352](libp2p/js-libp2p-kad-dht#352)) ([5244428](libp2p/js-libp2p-kad-dht@5244428))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So
peer:connectandpeer:disconnectare a bit misleading, as they actually have to do with muxed connections and our actual connection status to a peer. This creates problems for things like the Connection Manager that need to know about all connections in order to do its job properly. These events are used by many different things so changing their behaviors and replacing them with more appropriately named events isn't reasonable to do at this point.This introduces two new events,
connection:startandconnection:endthat can be used by the Connection Manager to better keep track of connections.