Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipfs cat in delegated routing example #475

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fix ipfs cat in delegated routing example #475

merged 1 commit into from
Nov 11, 2019

Conversation

phillmac
Copy link
Contributor

ipfs.files.cat is incorrect. the correct function is ipfs.cat

@phillmac
Fix ipfs cat
7481dee 
`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`
@jacobheun
Copy link
Contributor

The example is currently using js-ipfs ^0.34.x, did you verify the example runs with that? I don't recall when the API changed.

There is an open PR, #371, to update to a newer js-ipfs version, but the go-ipfs setup instructions need to get corrected. That PR uses the correct cat api.

@phillmac
Copy link
Contributor Author

Yup, I didn't modify the versions at all, using ~0.34.4, but I was getting ipfs.files.cat is not a function.
If the other pr is going to be merged then this one's redundant.

jacobheun
jacobheun approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It looks like the change was indeed made in 0.34. Going to merge this, I'm not sure when the other PR will get corrected, so I'd rather see this corrected now. Thanks for the PR!

@jacobheun jacobheun merged commit b733480 into libp2p:master Nov 11, 2019
dirkmc pushed a commit that referenced this pull request Nov 26, 2019
@phillmac @dirkmc
docs(example): fix ipfs cat (#475)
3f7289f 
`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`
dirkmc pushed a commit that referenced this pull request Nov 26, 2019
@phillmac @dirkmc
docs(example): fix ipfs cat (#475)
6712479 
`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`
dirkmc pushed a commit that referenced this pull request Nov 26, 2019
@phillmac @dirkmc
docs(example): fix ipfs cat (#475)
7459cae 
`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`
dirkmc pushed a commit that referenced this pull request Nov 26, 2019
@phillmac @dirkmc
docs(example): fix ipfs cat (#475)
eea675b 
`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`
jacobheun pushed a commit that referenced this pull request Nov 27, 2019
@dirkmc @jacobheun
refactor(docs): async await version of examples/echo (#483)
3fc352c 
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async await examples/echo

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example
jacobheun pushed a commit that referenced this pull request Nov 27, 2019
@dirkmc @jacobheun
refactor(docs): async await version of examples/chat (#482)
e5f8cad 
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async-await example chat

* fix: move handler before start

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example

* chore: remove unused vars
jacobheun pushed a commit that referenced this pull request Dec 12, 2019
@dirkmc @jacobheun
refactor(docs): async await version of examples/echo (#483)
b316cdd 
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async await examples/echo

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example
jacobheun pushed a commit that referenced this pull request Dec 12, 2019
@dirkmc @jacobheun
refactor(docs): async await version of examples/chat (#482)
995640e 
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async-await example chat

* fix: move handler before start

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example

* chore: remove unused vars
jacobheun pushed a commit that referenced this pull request Jan 24, 2020
@dirkmc @jacobheun
refactor(docs): async await version of examples/echo (#483)
953d185 
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async await examples/echo

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example
jacobheun pushed a commit that referenced this pull request Jan 24, 2020
@dirkmc @jacobheun
refactor(docs): async await version of examples/chat (#482)
472e14f 
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async-await example chat

* fix: move handler before start

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example

* chore: remove unused vars
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@achingbrain
fix: if client mode is specifed, do not auto-switch to server mode (l…
abe6a25 
…ibp2p#475)

If the user has specified client mode or not then do not auto-switch
between client or server mode.
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@semantic-release-bot
chore(release): 9.3.1 [skip ci]
2a96d52 
## [9.3.1](libp2p/js-libp2p-kad-dht@v9.3.0...v9.3.1) (2023-05-09)

### Bug Fixes

* if client mode is specifed, do not auto-switch to server mode ([libp2p#475](libp2p/js-libp2p-kad-dht#475)) ([abe6a25](libp2p/js-libp2p-kad-dht@abe6a25))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillmac @jacobheun