Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace peerInfo addresses with listen addresses #485

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Nov 26, 2019

No description provided.

@dirkmc dirkmc marked this pull request as ready for review November 27, 2019 23:10
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! Can you have a look at the linting failure?

@vasco-santos vasco-santos mentioned this pull request Nov 28, 2019
1 task
@vasco-santos
Copy link
Member

@dirkmc fyi I needed these changes in another PR, and as I think you are ooo today, I just fixed the linting 😛

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jacobheun jacobheun merged commit 860e582 into refactor/async-await Nov 28, 2019
@jacobheun jacobheun deleted the refactor/listen-addr branch November 28, 2019 15:45
jacobheun pushed a commit that referenced this pull request Dec 12, 2019
* feat: replace peer info addresses with listen addresses

* test: add listening test

* chore: fix linting
jacobheun pushed a commit that referenced this pull request Jan 24, 2020
* feat: replace peer info addresses with listen addresses

* test: add listening test

* chore: fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants