fix: ping multiaddr from peer not previously stored in peerstore #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/ping-multiaddr-from-peer-not-stored-in-peerstore
branch
from
18690b9
to
53ecde3
Compare
jacobheun
deleted the
fix/ping-multiaddr-from-peer-not-stored-in-peerstore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to ping using a multiaddr, under the hood we were trying to ping using the peer id but the address was not stored.
I added support for pinging using the multiaddr instead of adding the multiaddr to the addressBook because otherwise the ping could be done to a different multiaddr as a consequence of the parallel dials.
Context: https://discuss.libp2p.io/t/examples-failing-help-new-to-libp2p/620