feat: rendezvous integration #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
commented
Oct 5, 2020
| // Create rendezvous if provided | ||
| if (this._modules.rendezvous) { | ||
| const Rendezvous = this._modules.rendezvous | ||
| this.rendezvous = new Rendezvous({ |
There was a problem hiding this comment.
Considering that we will provide the libp2p.discovery API, I am thinking wether we should provide libp2p.rendezvous, or just leave it as libp2p._rendezvous. Thoughts?
If we keep this as it is, this PR should include API docs for rendezvous
vasco-santos
force-pushed
the
feat/rendezvous-integration
branch
from
c66a538 to
27dcc06
Compare
vasco-santos
force-pushed
the
feat/rendezvous-integration
branch
from
27dcc06 to
871741e
Compare
* feat: auto relay * fix: leverage protoBook events to ask relay peers if they support hop * chore: refactor disconnect * chore: do not listen on a relayed conn * chore: tweaks * chore: improve _listenOnAvailableHopRelays logic * chore: default value of 1 to maxListeners on auto-relay
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
force-pushed
the
feat/rendezvous-integration
branch
from
871741e to
699b4e5
Compare
vasco-santos
force-pushed
the
feat/rendezvous-integration
branch
from
699b4e5 to
f5b6ebe
Compare
|
Replaced by #856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of Improving libp2p discoverability and connectivity (#703), this PR integrates the new rendezvous implementations. This is the initial step for the discovery API, which is described in #768 and will have follow up PRs.
This PR integrates rendezvous as described in https://github.com/libp2p/js-libp2p-rendezvous/blob/feat/rendezvous-protocol-full-implementation/LIBP2P.md. The rendezvous module is provided in the libp2p config, and properly started and stopped with the node. Moreover, docs on how to configure a libp2p node acting as a rendezvous server, as well as a rendezvous client were added.
Needs:
Follow up work:
In the context of #768 , libp2p will provide a service discovery API, which will leverage the rendezvous if provided, content routing, and possibly other modules in the future. Once we have the discovery work done, it will be important to create a new example with the discovery API and rendezvous. Moreover, production guides for the server should be created