fix: demand pubsub class instead of pubsub instance #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the `Libp2pModules.pubsub` property to be a class that maybe extends `PubsubBaseProtocol` instead of an instance of that class. The `.dht` property could use the same treatment but that can be done in a follow up as the current `object` type doesn't cause an error.
achingbrain
changed the title
|
The DHT case needs to be better thought as we want to not have the DHT as dependency/devDependency in libp2p. We will defer this for #576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
Libp2pModules.pubsubproperty to be a class that maybeextends
PubsubBaseProtocolinstead of an instance of that class.The
.dhtproperty could use the same treatment but that can bedone in a follow up as the current
objecttype doesn't cause an error.