Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace node buffers with uint8arrays #127

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Aug 7, 2020

Replaces all uses of node Buffers with Uint8Arrays

Depends on:

BREAKING CHANGES:

  • Where node Buffers were returned, now Uint8Arrays are

Replaces all uses of node Buffers with Uint8Arrays

BREAKING CHANGES:

- Where node Buffers were returned, now Uint8Arrays are
@achingbrain
Copy link
Member Author

Tagging @Gozala too as he's not in the eligible reviewers list (yet).

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobheun jacobheun merged commit d16ce9c into master Aug 7, 2020
@jacobheun jacobheun deleted the fix/replace-node-buffers-with-unint8arrays branch August 7, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants