Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add large blob test #337

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

Nashatyrev
Copy link
Collaborator

@Nashatyrev Nashatyrev commented Oct 9, 2023

  • Add HostTestJava.largeBlob() test by @ianopolous (from Yamux is broken #334)
  • Add some flexibility to the HostBuilder
  • Add DebugHandlerBuilder.addCompactLogger() which adds a logger which shrinks too long messages

Co-authored-by: Dr Ian Preston ianopolous@protonmail.com

* Add ByteBufQueue tests
* Writing exec path is always through fill/drain buffer
* Adopt/fix existing tests
* Add new test checking correct handling of negative sendWindowSize
@Nashatyrev Nashatyrev mentioned this pull request Oct 9, 2023
@Nashatyrev Nashatyrev marked this pull request as ready for review October 10, 2023 12:10
Copy link
Collaborator

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashatyrev Nashatyrev merged commit 3ac83c4 into libp2p:develop Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants