Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remotePubKey in Noise secure Session #364

Merged

Conversation

Nashatyrev
Copy link
Collaborator

Noise negotiator was putting the wrong pubKey into SecureChannel.Session: local instead of remote

  • Fix the issue
  • Add a unit test

Copy link
Collaborator

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashatyrev
Copy link
Collaborator Author

Also increased the flaky test timeout. It indeed takes 10 seconds sometimes to complete

@Nashatyrev Nashatyrev enabled auto-merge (squash) May 15, 2024 11:52
@Nashatyrev Nashatyrev merged commit 838d7da into libp2p:develop May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants