Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOSSIP][BREAKING] Replace floodPublish param with floodPublishMaxMessageSizeThreshold #391

Merged
merged 7 commits into from
Oct 21, 2024
Merged

[GOSSIP][BREAKING] Replace floodPublish param with floodPublishMaxMessageSizeThreshold #391

merged 7 commits into from
Oct 21, 2024

Conversation

tbenr
Copy link
Collaborator

@tbenr tbenr commented Oct 21, 2024 •
edited
Loading

fixes #381

@tbenr tbenr changed the title floodPublishMaxMessageSizeThreshold [GOSSIP][BREAKING] Replace floodPublish param with floodPublishMaxMessageSizeThreshold Oct 21, 2024
Nashatyrev
Nashatyrev approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
just several nits

libp2p/src/main/kotlin/io/libp2p/pubsub/gossip/GossipParams.kt Show resolved Hide resolved
libp2p/src/main/kotlin/io/libp2p/pubsub/gossip/GossipParams.kt Outdated Show resolved Hide resolved
libp2p/src/main/kotlin/io/libp2p/pubsub/gossip/GossipParams.kt Outdated Show resolved Hide resolved
libp2p/src/main/kotlin/io/libp2p/pubsub/gossip/GossipRouter.kt Outdated Show resolved Hide resolved
@Nashatyrev
Copy link
Collaborator

Oh, would be great to have a unit test(s) for this parameter

@tbenr tbenr merged commit f4783eb into libp2p:develop Oct 21, 2024
2 checks passed
@tbenr tbenr deleted the floodPublishMaxMessageSizeThreshold branch October 21, 2024 13:59
@tbenr tbenr mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashatyrev Nashatyrev Nashatyrev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider converting floodPublish Gossip parameter to message size based
2 participants
@tbenr @Nashatyrev