-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/pull mplex #4
Merged
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
3c5caed
feat: initial commit
dryajov 7c6bdf1
feat: correct channel closing
dryajov 2798b03
feat: getting interface-stream-muxer tests to pass
dryajov 0987b24
feat: improve performance
dryajov c8f2115
feat: correct encoding/decoding
dryajov 117adbb
feat: correct encoding and channel closing
dryajov fb79753
feat: correct channel and plex closing
dryajov 284fd44
feat: interop with old libp2p-mplex
dryajov aeee3d9
fix: correctly read chunked data
dryajov 1a97616
feat: interep with old stream based mplex
dryajov e2f4579
feat: avoid negative sizes
dryajov 56694e0
feat: dont close channel too early
dryajov e9cd98d
feat: validation and coverage
dryajov 79f5a60
fix: correct channel id sequence
dryajov 487ff5d
feat: use bl to avoid buffer concat/copy
dryajov 2272897
chore: renaming back to pull-mplex
dryajov de7f5bb
chore: rename old to stream-mplex-interop
dryajov 66473b5
chore: adding misc files
dryajov bfd691e
chore: license
dryajov 3bc0908
feat: use two lists to avoid clashes
dryajov 18d43eb
style: formatting
dryajov dc95ed9
feat: remove unused deps
dryajov ff8e56a
feat: update README.md
dryajov b340326
feat: performance
dryajov 9a5a867
chore: update repo link
dryajov 6659c45
fix: dont use bl
dryajov 86eab54
perf: optimize
dryajov 1e9f794
style: fix formating
dryajov 64794fe
perf: improoving performance
dryajov 8c26286
style: remove unused variable
dryajov fa387c5
fix: msg length encoding
dryajov adc1884
fix: dont blow up the stack
dryajov 0fc4ca1
fix: use arrow function
dryajov 5c2c914
fix: remove initiator id logic
dryajov 3b29ca5
fix: start channel from 0
dryajov 1dbe5dc
chore: adding commitizen
dryajov 01fd7e3
feat: initial commit
dryajov 54a249b
feat: getting interface-stream-muxer tests to pass
dryajov 4c537d5
chore: remove unused file
dryajov 5431c65
feat: send chan name
dryajov 7f67df8
fix: send chan name when creating stream
dryajov c8a1c7e
fix: remove nyc_output file
dryajov a1d9788
chore: move benchmarks and inteop to libp2p-mplex
dryajov 22ef8d0
chore: remove non jenkins ci
jacobheun b895055
chore: update dependencies
jacobheun b59b1fe
fix: listen to the channel error
jacobheun 0eaf7d8
refactor: spread op instead of lodash defaults
jacobheun cb8b719
refactor: avoid toString when debug not enabled
jacobheun 03520cc
docs: add more comments
jacobheun ef06716
docs: add more js docs
jacobheun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed to fix an error with the test suite, because there was no error listener on channel. I need to do some more testing, but I don't think the channel needs to be emitting errors. It appears to be handling everything internally and reseting the stream properly, so I think it's probably redundant anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Channel should be emitting errors, but those needs to be catched here and logged. A lot of channel erroring might be a smell than it's better to tear down the connection?