Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap quick-protobuf::Error #3534

Closed
kckeiks opened this issue Mar 1, 2023 · 1 comment · Fixed by #3894
Closed

Wrap quick-protobuf::Error #3534

kckeiks opened this issue Mar 1, 2023 · 1 comment · Fixed by #3894
Milestone
v0.52.0

Comments

@kckeiks
Copy link
Contributor

kckeiks commented Mar 1, 2023

Description

In #3312 we introduced a wrapper around the quick-protobuf::Error type but had to remove the wrapped error because it introduced a breaking change related to auto traits.

Motivation

Provides more information about the error to users.

Current Implementation

We're not using quick-protobuf::Error as explained above.

Are you planning to do it yourself in a pull request?

No.
@kckeiks kckeiks mentioned this issue Mar 1, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger added this to the v0.52.0 milestone Mar 1, 2023
@thomaseizinger
Copy link
Contributor

Including this in v0.52 milestone. Once we decide to make a breaking change, we can fix the above and wrap the error again.

@thomaseizinger thomaseizinger mentioned this issue May 8, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #3894 May 12, 2023
mergify bot pushed a commit that referenced this issue May 12, 2023
@thomaseizinger
feat: properly encapsulate quick_protobuf::Error
1bf6264 
I noticed that we also still leak that dependency in several crates by providing a `From` impl so I've removed that one as well.

Resolves #3534.

Pull-Request: #3894.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.52.0
Development

Successfully merging a pull request may close this issue.

feat: properly encapsulate quick_protobuf::Error libp2p/rust-libp2p
2 participants
@thomaseizinger @kckeiks