Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kad: migrate to quick-protobuf-codec crate #4487

Closed
Tracked by #2500
thomaseizinger opened this issue Sep 12, 2023 · 2 comments · Fixed by #4501
Closed
Tracked by #2500

kad: migrate to quick-protobuf-codec crate #4487

thomaseizinger opened this issue Sep 12, 2023 · 2 comments · Fixed by #4501

Comments

@thomaseizinger
Copy link
Contributor

In /misc we have the quick-protobuf-codec crate which makes working with protobuf structs over streams quite easy as you only need to construct a asynchronous_codec::Framed type and can read and write full protobuf messages on any Async{Read,Write}.

We should make use of this in libp2p-kad.

See https://docs.rs/quick-protobuf-codec.

Previous tracking issue: #2500

@0xcrust
Copy link
Contributor

0xcrust commented Sep 12, 2023

@thomaseizinger I'd love to give this an attempt if you don't mind

@thomaseizinger
Copy link
Contributor Author

@thomaseizinger I'd love to give this an attempt if you don't mind

Great! I've assigned you! If you look through the tracking issue (#2500) you should be able to find several links to PRs where we've already done something similar! :)

Feel free to open a draft PR at any time if you need help.

@mergify mergify bot closed this as completed in #4501 Sep 15, 2023
mergify bot pushed a commit that referenced this issue Sep 15, 2023
StemCll pushed a commit to StemCll/rust-libp2p that referenced this issue Sep 17, 2023
thomaseizinger pushed a commit that referenced this issue Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants