Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noise: migrate to quick-protobuf-codec #4488

Closed
Tracked by #2500
thomaseizinger opened this issue Sep 12, 2023 · 2 comments · Fixed by #4548
Closed
Tracked by #2500

noise: migrate to quick-protobuf-codec #4488

thomaseizinger opened this issue Sep 12, 2023 · 2 comments · Fixed by #4548

Comments

@thomaseizinger
Copy link
Contributor

In /misc we have the quick-protobuf-codec crate which makes working with protobuf structs over streams quite easy as you only need to construct a asynchronous_codec::Framed type and can read and write full protobuf messages on any Async{Read,Write}.

We should make use of this in libp2p-noise.

See https://docs.rs/quick-protobuf-codec.

Previous tracking issue: #2500

@0xcrust
Copy link
Contributor

0xcrust commented Sep 15, 2023

Hello! I would like to also give this a shot

@thomaseizinger
Copy link
Contributor Author

Hello! I would like to also give this a shot

Sure thing! :)

@mergify mergify bot closed this as completed in #4548 Oct 26, 2023
mergify bot pushed a commit that referenced this issue Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants