Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap multistream-select streams under a Negotiated struct #1001

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

tomaka
Copy link
Member

@tomaka tomaka commented Mar 13, 2019

In preparation for #659, let's wrap all the multistream-select streams that succeed under a Negotiated struct.

Right now this is quite useless, but in the future the Negotiated would turn into something like:

pub enum Negotiated<T> {
    WaitingForHandshakeFinished(T),
    Finished(T),
}

This PR only adds the Negotiated so that we can discuss this part alone.

@ghost ghost assigned tomaka Mar 13, 2019
@ghost ghost added the in progress label Mar 13, 2019
Copy link
Contributor

@twittner twittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how this will work out eventually, but as an informative newtype Negotiated looks good to me.

@ghost ghost added the in progress label Mar 19, 2019
@tomaka tomaka merged commit 96e559b into libp2p:master Mar 19, 2019
@ghost ghost removed the in progress label Mar 19, 2019
@tomaka tomaka deleted the multistream-659 branch March 19, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants