Cleanups in libp2p-core in stable-futures branch #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that, unless we do some design refactoring, the substream upgrade infrastructure has to require Considering that all the helpers on |
twittner
reviewed
Dec 10, 2019
| fn poll_read(self: Pin<&mut Self>, cx: &mut Context, buf: &mut [u8]) -> Poll<Result<usize, IoError>> { | ||
| #[project] | ||
| match self.project() { | ||
| EitherOutput::First(a) => AsyncRead::poll_read(a, cx, buf), |
There was a problem hiding this comment.
Here and elsewhere you switched to UFCS style. What is the motivation for this change and what is the advantage here over writing a.poll_read(cx, buf)?
There was a problem hiding this comment.
It's just a habit from early days of futures-preview where it wasn't possible to write a.poll_read.
mxinden
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a few left-overs, and lots of
Unpintrait bounds replaced withpin-project.