Bump bytes to 0.5 #1367
Closed
Bump bytes to 0.5 #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bytes` 0.5 had a couple of breaking changes, specially the split of `Bytes` and `BytesMut`. Given how much this code use methods avaialable only on `BytesMut`, this comit changes the internal field to use this struct and some smaller code changes to adapt to it. Closes libp2p#1351
twittner
reviewed
Jan 3, 2020
| @@ -29,17 +29,17 @@ pub use self::protocol::Protocol; | |||
|
|
|||
| /// Representation of a Multiaddr. | |||
| #[derive(PartialEq, Eq, Clone, Hash)] | |||
| pub struct Multiaddr { bytes: Bytes } | |||
| pub struct Multiaddr { bytes: BytesMut } | |||
There was a problem hiding this comment.
Cloning Bytes is cheap, cloning BytesMut not so much. If we move away from Bytes we might as well use a Vec<u8> as we did in the past.
There was a problem hiding this comment.
I don't know much about memory cost of either. Would you like me to change to Vec<u8> on this PR?
There was a problem hiding this comment.
No, I think we should leave the implementation as is for the time being and not upgrade to bytes-0.5. Eventually we will probably want a custom copy-on-write implementation with cheap clones for shared Multiaddr values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytes0.5 had a couple of breaking changes, specially the split ofBytesandBytesMut.Given how much this code use methods avaialable only on
BytesMut, thiscomit changes the internal field to use this struct and some smaller
code changes to adapt to it.
Closes #1351