Add Swarm::next_extended #1374
Merged
Add Swarm::next_extended #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanb
approved these changes
Jan 6, 2020
swarm/src/lib.rs
Outdated
| /// Internal function used by everything event-related. | ||
| /// | ||
| /// Polls the `Swarm` for the next event. | ||
| fn poll_next_extended(mut self: Pin<&mut Self>, cx: &mut Context) |
There was a problem hiding this comment.
Suggested change
| fn poll_next_extended(mut self: Pin<&mut Self>, cx: &mut Context) | |
| fn poll_next_event(mut self: Pin<&mut Self>, cx: &mut Context) |
swarm/src/lib.rs
Outdated
| /// Returns the next event that happens in the `Swarm`. | ||
| /// | ||
| /// Includes events from the `NetworkBehaviour` but also events about the connections status. | ||
| pub async fn next_extended(&mut self) -> SwarmEvent<TBehaviour::OutEvent> { |
There was a problem hiding this comment.
Suggested change
| pub async fn next_extended(&mut self) -> SwarmEvent<TBehaviour::OutEvent> { | |
| pub async fn next_event(&mut self) -> SwarmEvent<TBehaviour::OutEvent> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is against
stable-futures.It fixes the situation with the
identifytest by adding aSwarmEventstruct containing more events such as "new listener address".The
Swarmnow has two new async methods:next()andnext_extended(). The former is the same as callingStream::next()except thatNoneis never returned. The latter is the same asnext()except that it returns aSwarmEvent.Additionally, polling the
Swarmno longer returns aResult.We can either merge before or after #1328, but this change should be in the CHANGELOG.