-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update async-std to 1.6.2 #1618
Conversation
3b8ff03
to
dcc3ee7
Compare
Ready for review, all tests are now passing out of the box, thanks to the diligent work from @stjepang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks @dignifiedquire @stjepang for the help!
As I have not been very involved in #1588 I will leave it up to the rest to approve.
Its a bummer that we can't just ignore 1.6.0
and 1.6.1
(See rust-lang/cargo#5286), but given that 1.5.0
and 1.6.2
are within the same major version I doubt any downstream dependency would complain being forced to update.
I'm trying this on Polkadot and it seems to work so far. 🚀 |
I'm still going to test more, but I think it's ok to merge this. |
Then we should wait with the merge until we have published the new libp2p version which will require |
It's been running for 4 hours now, and there isn't any anomaly in sight. |
Still no anomaly, everything running smoothly. |
(still testing, will mark as ready when I am confident it is working)Ref #1612