Restore RequestResponse::throttled.
#1715
Conversation
twittner
force-pushed
the
throttled-fix
branch
3 times, most recently
from
77ddfb3
to
94f5671
Compare
twittner
force-pushed
the
throttled-fix
branch
2 times, most recently
from
87a0f25
to
fc692f1
Compare
|
Would you mind rebasing or merging |
Fix the budget calculation using `ProtocolsHandler::InboundOpenInfo`.
Create events when connection closed.
twittner
force-pushed
the
throttled-fix
branch
from
067c3d3
to
b88141b
Compare
|
Thinking a little more about the approach here I think we have a race condition w.r.t. timeouts and errors. If the sender of a request times out or errors earlier than the receiver it grants itself another request. Should that request reach the receiver before it has detected the timeout or error and likewise allowed another request from the sender, it would potentially generate a Without a way to give credit to a remote that is independent of receiving a request, i.e. being able to send unidirectional and unsolicited credit grants (which allows the receiver to retry sending the credit after a timeout or error) there is always a need for both ends to adjust their credit views which leads to inconsistencies as described above. |
|
Ultimately superseded by #1726. |
Fixes #1706.
Continuation of #1714.