Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiaddr: feature gate url dependency #1843

Merged
merged 2 commits into from
Nov 17, 2020
Merged

multiaddr: feature gate url dependency #1843

merged 2 commits into from
Nov 17, 2020

Conversation

mzabaluev
Copy link
Contributor

Resolves #1836

@mzabaluev
multiaddr: feature gate url dependency
1c952b1 
Make it possible to exclude url and its dependencies
from the dependency tree, by feature gating the
from_url* functions in the public API.
@mzabaluev
Document feature gating of multiaddr::from_url*
9c6dc5f
romanb
romanb approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@romanb romanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@romanb romanb merged commit fe6e622 into libp2p:master Nov 17, 2020
@romanb
Copy link
Contributor

romanb commented Nov 17, 2020

Published as parity-multiaddr-0.9.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@romanb romanb romanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiaddr: Feature gate for URL support
3 participants
@mzabaluev @romanb @mxinden