core/tests/connection_limit: Fix flake in max_established_incoming #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test `max_established_incoming` starts two networks with a configured connection limit, spawns up to `limit + 1` connections and expects the last connection to be closed due to being over the limit. The previous test implementation depended on both networks to handle each connection in sequence, which is not always the case. E.g. while network 2 might expect the last connection to close, network 1 might finish upgrading the last connection before the second to last connection, thus expecting the second to last connection to close. This commit drives network 1 and 2 in sequence and ensures both networks are finished upgrading a connection before starting a new connection. In addition it upgrade the test to use `quickcheck`.
3 tasks
|
@thomaseizinger can you take a look? It is not ideal (mostly due to the conflicts resulting from |
Will have a look tomorrow! |
thomaseizinger
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
max_established_incomingstarts two networks with aconfigured connection limit, spawns up to
limit + 1connections andexpects the last connection to be closed due to being over the limit.
The previous test implementation depended on both networks to handle
each connection in sequence, which is not always the case.
E.g. while network 2 might expect the last connection to close, network
1 might finish upgrading the last connection before the second to last
connection, thus expecting the second to last connection to close.
This commit drives network 1 and 2 in sequence and ensures both networks
are finished upgrading a connection before starting a new connection. In
addition it upgrade the test to use
quickcheck.