Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add Serialize and Deserialize to PeerId gossipsub MessageId and kad Key #2408

Merged
merged 17 commits into from
Jan 11, 2022
Merged

*: Add Serialize and Deserialize to PeerId gossipsub MessageId and kad Key #2408

merged 17 commits into from
Jan 11, 2022

Conversation

laptou
Copy link
Contributor

@laptou laptou commented Dec 29, 2021

Continuation of #2405 on a new branch.

thomaseizinger
thomaseizinger reviewed Dec 29, 2021
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion on how we can use serde as the feature name. That would be a cleaner API IMO :)

core/src/peer_id.rs Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger requested changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Sorry for the turn-around but I have another concern.

core/src/peer_id.rs Outdated Show resolved Hide resolved
@laptou
Copy link
Contributor Author

laptou commented Dec 30, 2021

I also derived Serialize, Deserialize for kad::store::record::Key. Let me know if you want this in a separate PR, or if I can squeeze it into this one 😁

thomaseizinger
thomaseizinger approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this effort!

One non-blocking comment so good to go in from my side. Any more considerations @mxinden ?

core/tests/serde.rs Show resolved Hide resolved
mxinden
mxinden reviewed Jan 10, 2022
View reviewed changes
core/src/peer_id.rs Outdated Show resolved Hide resolved
protocols/kad/src/record.rs Show resolved Hide resolved
laptou and others added 2 commits January 10, 2022 14:03
@laptou laptou requested a review from mxinden January 10, 2022 19:03
mxinden
mxinden approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @laptou!

protocols/kad/src/record.rs Show resolved Hide resolved
@mxinden mxinden changed the title core: Add Serialize and Deserialize to PeerId and MessageId *: Add Serialize and Deserialize to PeerId gossipsub MessageId and kad Key Jan 11, 2022
@mxinden mxinden merged commit 5617481 into libp2p:master Jan 11, 2022
@laptou laptou deleted the use-serde branch January 11, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laptou @thomaseizinger @mxinden