Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocols/kad: Derive Clone for KademliaEvent #2411

Merged
merged 5 commits into from
Dec 30, 2021
Merged

protocols/kad: Derive Clone for KademliaEvent #2411

merged 5 commits into from
Dec 30, 2021

Conversation

laptou
Copy link
Contributor

@laptou laptou commented Dec 29, 2021

  • derive Clone for KademliaEvent and related structures

I was motivated to make this change so that I could send KademliaEvent across broadcast channels.

@thomaseizinger thomaseizinger changed the title kad: derive Clone for KademliaEvent kad: Derive Clone for KademliaEvent Dec 30, 2021
thomaseizinger
thomaseizinger approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mxinden
mxinden reviewed Dec 30, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me. Would you mind adding a changelog entry to protocols/kad/CHANGELOG.md @laptou?

@laptou
Copy link
Contributor Author

laptou commented Dec 30, 2021

+1 Looks good to me. Would you mind adding a changelog entry to protocols/kad/CHANGELOG.md @laptou?

done

@laptou laptou requested a review from mxinden December 30, 2021 16:13
@mxinden mxinden changed the title kad: Derive Clone for KademliaEvent protocols/kad: Derive Clone for KademliaEvent Dec 30, 2021
@mxinden mxinden merged commit b4468d7 into libp2p:master Dec 30, 2021
@laptou laptou deleted the kad-query-clone branch December 30, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laptou @thomaseizinger @mxinden