Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/muxing: Replace Into<io::Error> bound on StreamMuxer with std::error::Error #2710

Merged
merged 9 commits into from
Jun 24, 2022
Merged

core/muxing: Replace Into<io::Error> bound on StreamMuxer with std::error::Error #2710

merged 9 commits into from
Jun 24, 2022

Commits on Jun 23, 2022

  1. core/muxing: Remove Into<io::Error> bound from StreamMuxer::Error 

    This allows us to preserve the type information of a muxer's concrete
error as long as possible. For `StreamMuxerBox`, we leverage `io::Error`'s
capability of wrapping any error that implements `Into<Box<dyn Error>>`.
    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    ed371e1 View commit details
    Browse the repository at this point in the history

  2. Use ? in Connection::poll

    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    8e222b1 View commit details
    Browse the repository at this point in the history

  3. Use ? in muxing::boxed::Wrap

    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    88ce2f0 View commit details
    Browse the repository at this point in the history

  4. Use futures::ready! in muxing::boxed::Wrap

    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    6cce828 View commit details
    Browse the repository at this point in the history

  5. Fill PR number into changelog

    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    0dea55f View commit details
    Browse the repository at this point in the history

  6. Put Error + Send + Sync bounds directly on StreamMuxer::Error

    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    e017cae View commit details
    Browse the repository at this point in the history

  7. Move Send + Sync bounds to higher layers

    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    b5da12f View commit details
    Browse the repository at this point in the history

  8. Use map_inbound_stream helper

    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    80a35b8 View commit details
    Browse the repository at this point in the history

  9. Update changelog to match new implementation

    @thomaseizinger
    thomaseizinger committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    a28a7c5 View commit details
    Browse the repository at this point in the history